Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #25017 -- Allowed customizing the settings.DISALLOWED_USER_AGENTS response. #4915

Closed
wants to merge 1 commit into from
Closed

Fixed #25017 -- Allowed customizing the settings.DISALLOWED_USER_AGENTS response. #4915

wants to merge 1 commit into from

Conversation

SujaySKumar
Copy link
Contributor

claudep
claudep reviewed Jun 24, 2015
View reviewed changes
tests/middleware/tests.py
r = CommonMiddleware().process_request(request)
self.assertEqual(r.status_code, 403)
self.assertEqual(log_messages, ['Forbidden (User agent): /slash'])
with self.assertRaises(self, PermissionDenied):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No self parameter, just the exception class.

@timgraham timgraham changed the title settings.DISALLOWED_USER_AGENTS throws a PermissionDenied exception a… Fixed #25017 -- Allowed customizing the settings.DISALLOWED_USER_AGENTS response. Jun 26, 2015
@timgraham
Copy link
Member

Could you draft a release note for 1.9 in the "Requests and Responses" section? Also please squash commits and use the commit message from the title of this pull request. Thanks!

@SujaySKumar SujaySKumar force-pushed the ticket_25017 branch 2 times, most recently from 0f72458 to 17bd0f1 Compare June 26, 2015 20:41
@SujaySKumar
Copy link
Contributor Author

Hi Tim,
I have followed the instructions you mentioned in the comments. You can now
merge the branch with master. Thanks!

Regards,
Sujay S Kumar

On Fri, Jun 26, 2015 at 7:42 PM, Tim Graham notifications@github.com
wrote:

Could you draft a release note for 1.9 in the "Requests and Responses"
section? Also please squash commits and use the commit message from the
title of this pull request. Thanks!

—
Reply to this email directly or view it on GitHub
#4915 (comment).

@timgraham
Copy link
Member

merged in 2e70bf3, thanks!

@timgraham timgraham closed this Jun 27, 2015
@codingjoe codingjoe mentioned this pull request Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SujaySKumar @timgraham @claudep