Fixed #25226 -- Set the model attribute on the base_field in ArrayField #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timgraham The fix for ArrayField was quite trivial. I din't create a ticket yet for it in Trac. Should I do that? (re: #5084) |
|
Yes please. Only typos or trivial refactorings may be merged without a ticket. |
|
Sure. I'll do that. |
|
Linking the Trac ticket here: https://code.djangoproject.com/ticket/25226 |
timgraham
changed the title
|
merged in 5208021, thanks! |
adamchainz
pushed a commit
to adamchainz/django-mysql
that referenced
this pull request
Aug 18, 2015
…and the way the `check` tests were done on fields. As exposed by django/django#5084 ; copying fix as per django/django#5104
adamchainz
pushed a commit
to adamchainz/django-mysql
that referenced
this pull request
Aug 19, 2015
…and the way the `check` tests were done on fields. As exposed by django/django#5084 ; copying fix as per django/django#5104
adamchainz
pushed a commit
to adamchainz/django-mysql
that referenced
this pull request
Aug 19, 2015
…and the way the `check` tests were done on fields. As exposed by django/django#5084 ; copying fix as per django/django#5104
adamchainz
pushed a commit
to adamchainz/django-mysql
that referenced
this pull request
Aug 19, 2015
…and the way the `check` tests were done on fields. As exposed by django/django#5084 ; copying fix as per django/django#5104
jellaDolphin
added a commit
to jellaDolphin/django-mysql
that referenced
this pull request
Mar 24, 2022
…and the way the `check` tests were done on fields. As exposed by django/django#5084 ; copying fix as per django/django#5104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayField doesn't set the model attribute on the base_field, causing check framework backend specific checks to fail for #5084