New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused attrs argument in BoundField as_*() methods. #5170

Closed

timgraham wants to merge 1 commit into django:master from timgraham:boundfield-attrs

Member

timgraham commented Aug 21, 2015

This was never used as of its introduction in
4d596a1.


          Removed unused attrs argument in BoundField as_*() methods.

3c0e1b4

This was never used as of its introduction in
4d596a1.

Member Author

timgraham commented Aug 21, 2015

There is a use case for as_widget() though. In one of my projects I have a template filter that is called add_class and I use it like this:

{{ my_form.my_field|add_class:'class-added-to-input-field' }}

Although this use case may be invalidated by the upcoming template based widget rendering.

Although it's not a public API, it would probably be good to have a deprecation patch if we do this.

timgraham closed this

timgraham deleted the boundfield-attrs branch

August 22, 2015 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet