Fixed #17688 -- Added actions to m2m_changed for deleted objects. #5505
Conversation
| attr_name = m2m_relation.name | ||
| sender = m2m_relation.remote_field.through | ||
| else: | ||
| assert(isinstance(m2m_relation, ManyToManyRel)) |
There was a problem hiding this comment.
What about using an elif isinstance(m2m_relation, ManyToManyRel) clause instead and issuing a continue in an else branch? This looks more safe in regard to third party fields that might exposed them as many_to_many = True.
There was a problem hiding this comment.
Thanks for reviewing this PR. I agree, with this and all your other suggestions. They were incorporated in the new version of the PR. Also, the failing tests now should pass.
| sender = m2m_relation.remote_field.through | ||
| elif isinstance(m2m_relation, ManyToManyRel): | ||
| attr_name = m2m_relation.get_accessor_name() | ||
| sender = m2m_relation.through |
There was a problem hiding this comment.
I can't come up with a way to differentiate both instance either. Ideally they would have a similar API.
There was a problem hiding this comment.
I guess it can be cleaned up once https://code.djangoproject.com/ticket/24317 is resolved?
|
Needs a mention in the 1.10 release notes. |
|
Closing due to inactivity. Please send a new PR if you return to it. |
Ticket: https://code.djangoproject.com/ticket/17688