Fixed #25663 -- Added checking of the number of points for LinearRing and LineString.
#5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sir-sigurd
force-pushed
the
check-linear-init-args
branch
from
67dcad7
to
45c6867
Compare
| @@ -28,7 +27,7 @@ | |||
|
|
|||
|
|
|||
| @skipUnless(HAS_GEOS, "Geos is required.") | |||
| class GEOSTest(unittest.TestCase, TestDataMixin): | |||
| class GEOSTest(TestCase, TestDataMixin): | |||
There was a problem hiding this comment.
Use a SimpleTestCase instead as it provides assertRaisesMessage and avoids wrapping each test case in a transaction which is not required here.
There was a problem hiding this comment.
Fixed, thanks for the note.
sir-sigurd
force-pushed
the
check-linear-init-args
branch
from
45c6867
to
8877512
Compare
| self._checkdim(ndim) | ||
| if ncoords < self._minlength: | ||
| raise TypeError( | ||
| '`%s` requires at least %d point, got %s.' % (self.__class__.__name__, self._minlength, ncoords) |
sir-sigurd
force-pushed
the
check-linear-init-args
branch
from
8877512
to
1ff4156
Compare
…g` and `LineString`.
sir-sigurd
force-pushed
the
check-linear-init-args
branch
from
1ff4156
to
2385ba3
Compare
|
merged in 1e35dd1, thanks! For future reference, in Django I haven't seen your convention of including backticks around class names in commit messages, exception messages, etc, so I suggest to be consistent with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/25663