Fixed #25637 -- Added URLValidator hostname length validation. #5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,9 +83,9 @@ class URLValidator(RegexValidator): | |||
| ipv6_re = r'\[[0-9a-f:\.]+\]' # (simple regex, validated later) | |||
|
|
|||
| # Host patterns | |||
| hostname_re = r'[a-z' + ul + r'0-9](?:[a-z' + ul + r'0-9-]*[a-z' + ul + r'0-9])?' | |||
There was a problem hiding this comment.
I'd add a comment as done for EmailValidator: "# Max length for domain name labels is 63 characters per RFC 1034."
timgraham
changed the title
raphaelm
force-pushed
the
ticket_25637
branch
from
bfceb26
to
9bbe5aa
Compare
|
I changed the comments with respect to your suggestions. |
URLValidator now validates the maximum length of a hostname in total and the maximum length of all labels inside the hostname. The label validation is done in the regular expression while the hostname length check is implemented by introducing a new check in the validator's __call__ method. Please note that the additional call on urlsplit() introduced there should not be a measurable performance overhead, as urlsplit is called anyway in some of the code branches above and the standard-library implementation uses an internal result cache.
raphaelm
force-pushed
the
ticket_25637
branch
from
9bbe5aa
to
0ce6c42
Compare
|
merged in 82976e5, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLValidator now validates the maximum length of a hostname in total
and the maximum length of all labels inside the hostname. The label
validation is done in the regular expression while the hostname length
check is implemented by introducing a new check in the validator's
call method. Please note that the additional call on urlsplit()
introduced there should not be a measurable performance overhead, as
urlsplit is called anyway in some of the code branches above and the
standard-library implementation uses an internal result cache.