Fixed #25657 -- Ignored TypeErrors when destroying geometry objects #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,8 +87,10 @@ def __init__(self, ds_input, ds_driver=False, write=False, encoding='utf-8'): | |||
|
|
|||
| def __del__(self): | |||
| "Destroys this DataStructure object." | |||
| if self._ptr and capi: | |||
There was a problem hiding this comment.
and capi was added in 8f334e5 to prevent AttributeError, was it unneeded?
There was a problem hiding this comment.
Good catch, seems we also have to catch AttributeError.
|
Does this fix make this note unneeded? |
|
Hopefully yes. I'm not completely sure we solved all such cases. |
|
Add code comments to make the purpose clear for future readers? |
Due to randomness of garbage collection with geometry objects, it's easier to simply ignore AttributeError/TypeError generally raised when parts of objects are already garbage-collected. Thanks Sergey Fedoseev and Tim Graham for reviewing the patch.
|
Something like that? |
|
sure, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to randomness of garbage collection with geometry objects, it's
easier to simply ignore TypeErrors generally raised when parts of
objects are already garbage-collected.