Refs #15667 -- Fixed crash when indexing RadioFieldRenderer with ModelChoiceIterator. #6794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
referenced
this pull request
Jun 17, 2016
RendererMixin will soon be removed but this removal and the corresponding test changes stand on their own.
|
Hi @timgraham! Thanks! At first glance it looks like it will work for us (for Wagtail CMS). I will be able to check this on Sunday. |
…h ModelChoiceIterator. Regression in 8657386
|
I'll merge this now since the beta release is scheduled for today. If it doesn't work for you, please file a ticket with details. |
|
Thanks Tim! It works well! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression in 8657386