Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #25251: update settings.SERIALIZE description related to --keepdb issue. #6873

Closed
wants to merge 1 commit into from

Conversation

romgar
Copy link
Contributor

@romgar romgar commented Jul 2, 2016

Using SERIALIZE = False prevents tests with serialize_rollback = True to work as expected, and is described in the documentation.
But it will also prevent the --keepdb option to properly keep the serialized initia data at the end of the test suite.
This PR is updating the documentation according to this, and is related to some discussions with @timgraham in #6297.

…ty between serialized_rollback=True and settings.SERIALIZE=False
@romgar romgar force-pushed the ticket_25251_documentation branch from 7b16425 to ac4770c Compare July 2, 2016 23:37
@timgraham
Copy link
Member

Do you think this is a bit more clear?

If you have data migrations and use :class:`~django.test.TransactionTestCase`
along with the :option:`test --keepdb` option, you won't see data from
migrations in subsequent ``--keepdb`` test runs if you set ``SERIALIZE`` to
``False``.

@romgar
Copy link
Contributor Author

romgar commented Jul 9, 2016

@timgraham That's definitely clearer.

I'm just wondering if it makes sense at the end to update this documentation on a separate PR than #6297.
Indeed, users won't see data migrations in subsequent --keepdb test runs if they set SERIALIZE to either True or False (until we fix https://code.djangoproject.com/ticket/25251), which is a bit misleading when we read the doc update in this PR.

@timgraham
Copy link
Member

Sure, you can put this with that PR.

@timgraham timgraham closed this Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants