Make sure these functions don't bleed into the global scope #70

Merged
merged 4 commits into from May 18, 2012

Conversation

Projects
None yet
3 participants
@tswicegood
Contributor

tswicegood commented May 16, 2012

This makes sure that all of these functions are assigned to variables
assigned to the current scope, rather than the global scope. It also adds a
trailing semi-colon to make sure various linters are happy.

tswicegood added some commits May 16, 2012

Make sure these functions don't bleed into the global scope
This makes sure that all of these functions are assigned to variables
assigned to the current scope, rather than the global scope.  It also
adds a trailing semi-colon to make sure various linters are happy.
@adrianholovaty

This comment has been minimized.

Show comment
Hide comment
@adrianholovaty

adrianholovaty May 18, 2012

Member

Thanks for this cleanup, @tswicegood!

Member

adrianholovaty commented May 18, 2012

Thanks for this cleanup, @tswicegood!

adrianholovaty added a commit that referenced this pull request May 18, 2012

Merge pull request #70 from tswicegood/fix-js-scope
Cleaned up various JavaScript in admin JS.

@adrianholovaty adrianholovaty merged commit 4b75546 into django:master May 18, 2012

@jezdez

This comment has been minimized.

Show comment
Hide comment
@jezdez

jezdez May 20, 2012

Member

Hm, seems like there was a ticket open, too. Please for the love of god, mention ticket numbers when creating pull requests.

Member

jezdez commented May 20, 2012

Hm, seems like there was a ticket open, too. Please for the love of god, mention ticket numbers when creating pull requests.

@tswicegood

This comment has been minimized.

Show comment
Hide comment
@tswicegood

tswicegood May 20, 2012

Contributor

Doh! Didn't see the issue when I searched. :-/

Contributor

tswicegood commented May 20, 2012

Doh! Didn't see the issue when I searched. :-/

@tswicegood

This comment has been minimized.

Show comment
Hide comment
@tswicegood

tswicegood May 20, 2012

Contributor

Oh wait -- was it the ticket I opened? I did the reverse reference from it to here I thought...? My workflow is generally create the PR first, then the ticket in Trac as housekeeping assuming it looks good to other people.

I'll try to make sure to update the description on PRs once a ticket is open though.

Contributor

tswicegood commented May 20, 2012

Oh wait -- was it the ticket I opened? I did the reverse reference from it to here I thought...? My workflow is generally create the PR first, then the ticket in Trac as housekeeping assuming it looks good to other people.

I'll try to make sure to update the description on PRs once a ticket is open though.

@jezdez

This comment has been minimized.

Show comment
Hide comment
@jezdez

jezdez May 21, 2012

Member

Right, the problem occurs when a pull request is merged without knowing there is a ticket. The green button is rather tempting ;)

Member

jezdez commented May 21, 2012

Right, the problem occurs when a pull request is merged without knowing there is a ticket. The green button is rather tempting ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment