Make sure these functions don't bleed into the global scope #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that all of these functions are assigned to variables assigned to the current scope, rather than the global scope. It also adds a trailing semi-colon to make sure various linters are happy.
|
Thanks for this cleanup, @tswicegood! |
adrianholovaty
added a commit
that referenced
this pull request
May 18, 2012
Cleaned up various JavaScript in admin JS.
|
Hm, seems like there was a ticket open, too. Please for the love of god, mention ticket numbers when creating pull requests. |
|
Doh! Didn't see the issue when I searched. :-/ |
|
Oh wait -- was it the ticket I opened? I did the reverse reference from it to here I thought...? My workflow is generally create the PR first, then the ticket in Trac as housekeeping assuming it looks good to other people. I'll try to make sure to update the description on PRs once a ticket is open though. |
|
Right, the problem occurs when a pull request is merged without knowing there is a ticket. The green button is rather tempting ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that all of these functions are assigned to variables
assigned to the current scope, rather than the global scope. It also adds a
trailing semi-colon to make sure various linters are happy.