Fixed #27467 -- Made UserAttributeSimilarityValidator max_similarity=0/1 work as documented. #7534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
27467
branch
3 times, most recently
from
a6300f4
to
8523d8f
Compare
raminfp
reviewed
Nov 13, 2016
| A setting of 0 will cause all passwords to be rejected, whereas a setting | ||
| of 1 will cause it to only reject passwords that are identical to an | ||
| attribute's value. | ||
| The minimum similarity of a rejected password can be be set on a scale of 0 |
…0/1 work as documented. Thanks goblinJoel for the report and feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs says, "The maximum similarity the password can have, before it is rejected, can be set with the max_similarity parameter, on a scale of 0 to 1. A setting of 0 will cause all passwords to be rejected, whereas a setting of 1 will cause it to only reject passwords that are identical to an attribute’s value."
Both tests fail without the fix.
https://code.djangoproject.com/ticket/27467