Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used @cached_property in RawQuerySet. #7735

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Used @cached_property in RawQuerySet. #7735

merged 1 commit into from
Dec 23, 2016

Conversation

adamchainz
Copy link
Sponsor Member

Noticed whilst reading to review #7727. cached_property implements exactly the pattern that was in use.

apollo13
apollo13 approved these changes Dec 23, 2016
View reviewed changes
Copy link
Member

@apollo13 apollo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, merge if tests pass…

@timgraham timgraham changed the title Improved RawQuerySet with cached_property Used @cached_property in RawQuerySet. Dec 23, 2016
@timgraham timgraham merged commit 8d94d57 into django:master Dec 23, 2016
@adamchainz adamchainz deleted the RawQuerySet_cached_property branch April 22, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charettes charettes charettes approved these changes

@apollo13 apollo13 apollo13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamchainz @charettes @apollo13 @timgraham