Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganized backends tests. #8053

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Reorganized backends tests. #8053

merged 1 commit into from
Jun 21, 2017

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Feb 11, 2017

I reorganized backends specific tests (see #8015 (comment), and ticket 23027).

@timgraham timgraham mentioned this pull request Feb 16, 2017
Merged
@felixxm felixxm force-pushed the refs-23027 branch 2 times, most recently from 7610ec4 to 7b5a804 Compare February 20, 2017 11:41
@felixxm felixxm force-pushed the refs-23027 branch 5 times, most recently from d20da4d to 5a1a921 Compare April 25, 2017 14:13
@felixxm
Copy link
Member Author

felixxm commented May 15, 2017

I rebased from master.

@timgraham timgraham changed the title Refs #23027 -- Reorganized backends specific tests. Reorganized backends tests. Jun 20, 2017
@timgraham timgraham force-pushed the refs-23027 branch 2 times, most recently from 86d9aef to d2ac934 Compare June 20, 2017 14:48
@timgraham
Copy link
Member

I worked on this today. Some notable changes:

  • I created a db_utils test app for testing django.db.utils (stuff that's not in django.db.backends).
  • I moved most of tests/backends/base/tests.py (now renamed to test_base.py) back to tests/backends/tests.py and added a docstring to that file that those tests are unorganized. Those tests are tests all sorts of things unrelated to the base backend, so I think we should just leave them alone for now in order to get this merged.

I'm going to give this a break for now and probably look at it again later this week.

@felixxm
Copy link
Member Author

felixxm commented Jun 20, 2017

@timgraham Thanks! 🚀

@timgraham timgraham merged commit 8cb1b1f into django:master Jun 21, 2017
@felixxm felixxm deleted the refs-23027 branch June 22, 2017 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixxm @timgraham