[WIP] Added filter field to the right column for FilteredSelectMultiple wid… #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get. Refs #24179.
|
Functionality looks like what I would expect. Still, I think it should be more obvious that the non-filtered list will be submitted. Perhaps you could look into how other widgets handle this. I wonder if we even might find an existing jQuery plugin or similar that could replace our homegrown solution (https://code.djangoproject.com/ticket/15220). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…get. Refs #24179.
I have added the new feature. It's currently for 1.8 version. Please see if the functionality is correct and I will update it for the master branch. Please don't review the code itself. It will need refactoring after the functionality is confirmed.