Fixed #26257 -- Added support for expressions in model's Meta.ordering #8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimaKudosh
force-pushed
the
ticket_28335
branch
2 times, most recently
from
1d397e5
to
135e850
Compare
timgraham
changed the title
timgraham
reviewed
Jul 5, 2017
There was a problem hiding this comment.
Documentation updates for Meta.ordering and release notes are needed. Check your work using the patch review checklist. Thanks!
tests/ordering/tests.py
Outdated
| Test of using F expressions in default ordering. (#28335) | ||
| """ | ||
| articles = OrderedByFExpressionArticle.objects.all() | ||
| articles.filter(headline="Article 2").update(author=self.author_2) |
There was a problem hiding this comment.
Use single quotes (unless a string contains a single quote) as described in Python coding style.
tests/ordering/tests.py
Outdated
|
|
||
| def test_default_order_by_f_expression(self): | ||
| """ | ||
| Test of using F expressions in default ordering. (#28335) |
There was a problem hiding this comment.
Docstrings should state the expected behavior and omit prefixes like "Tests that" since all tests test things. Ticket references should be reserved for obscure issues (not needed here). These guidelines are from Python coding style.
DimaKudosh
force-pushed
the
ticket_28335
branch
2 times, most recently
from
d5a1930
to
e832abd
Compare
|
Added documentation and release note |
|
A |
timgraham
force-pushed
the
ticket_28335
branch
from
9ea2181
to
093fd47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26257