Fix qs.order_by() join promotion for already existing joins #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When order_by causes new joins to be added to the query, the joins must be LEFT OUTER joins for nullable relations, otherwise the order_by could cause the results to be altered. This commit fixed the logic to only promote new joins, previously all applicable joins were promoted. Thanks to Bruno Desthuilliers for spotting this corner case.
|
Pushed in manually in 8c72aa2 |
sztrovacsek
pushed a commit
to sztrovacsek/django
that referenced
this pull request
Mar 7, 2015
Working through tutorial independently online.
nanuxbe
pushed a commit
to nanuxbe/django
that referenced
this pull request
Jul 2, 2016
Remove stray comment fragment at end of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When order_by causes new joins to be added to the query, the joins must
be LEFT OUTER joins for nullable relations, otherwise the order_by
could cause the results to be altered. This commit fixed the logic to
only promote new joins, previously all applicable joins were promoted.
Thanks to Bruno Desthuilliers for spotting this corner case.