Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28710 -- Fixed the Basque DATE_FORMAT string #9237

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

claudep
Copy link
Member

@claudep claudep commented Oct 13, 2017

Thanks Eneko Illarramendi for the report and initial patch.

@timgraham
Copy link
Member

Please add with self.subTest(locale=locale): after the for loop (except on stable/1.11.x where Python 2 support is needed).

@claudep
Copy link
Member Author

claudep commented Oct 13, 2017

Don't you mind combining the with conditions?
with self.subTest(locale=locale), translation.override(locale):

@timgraham
Copy link
Member

I tried that locally but it didn't seem to work.

@claudep
Copy link
Member Author

claudep commented Oct 13, 2017

Weird, it works fine on my system (Python 3.5). What error do you get?

@timgraham
Copy link
Member

I guess I had made a mistake earlier, seems to work now.

Thanks Eneko Illarramendi for the report and initial patch.
@claudep claudep closed this Oct 13, 2017
@claudep claudep deleted the 28710 branch October 13, 2017 17:49
@claudep claudep merged commit 8c53887 into django:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants