Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28735 -- Fixed typo in django/views/templates/default_urlconf.html. #9279

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

shacker
Copy link
Contributor

@shacker shacker commented Oct 24, 2017

@timgraham
Copy link
Member

I don't think "for this page" is correct (that language isn't present in older versions of Django). The default_urlconf view is used if the URLconf is empty or if the default URLconf is present.

if (not tried or ( # empty URLconf
request.path == '/' and
len(tried) == 1 and # default URLconf
len(tried[0]) == 1 and
getattr(tried[0][0], 'app_name', '') == getattr(tried[0][0], 'namespace', '') == 'admin'
)):
return default_urlconf(request)

@timgraham timgraham changed the title Improve language on default "It Worked!" view Fixed #28735 -- Fixed typo in django/views/templates/default_urlconf.html. Oct 24, 2017
@timgraham timgraham merged commit 6642a64 into django:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants