Fixed #28950 -- Fixed ArrayField.has_changed() for empty values. #9520
Conversation
tests/postgres_tests/test_array.py
Outdated
| @@ -737,6 +737,14 @@ def test_already_converted_value(self): | |||
| vals = ['a', 'b', 'c'] | |||
| self.assertEqual(field.clean(vals), vals) | |||
|
|
|||
| def test_has_changed(self): | |||
| field = SimpleArrayField(forms.CharField()) | |||
| self.assertFalse(field.has_changed(None, None)) | |||
There was a problem hiding this comment.
use self.assertIs(..., False) (assertFalse checks bool(val) is False)
tests/postgres_tests/test_array.py
Outdated
| field = SimpleArrayField(forms.CharField()) | ||
| self.assertFalse(field.has_changed(None, None)) | ||
| self.assertFalse(field.has_changed(None, '')) | ||
| self.assertFalse(field.has_changed(None, [])) |
There was a problem hiding this comment.
Are [], None, and '' all realistic values for data? Generally I would expect only string values from POST data.
There was a problem hiding this comment.
for an empty field '' is passed in POST data.
if you are referring to pure html form implementation, then None and [] are not encountered. but if the form is used otherwise (validating api requests) you might expect to see these values.
| try: | ||
| data_value = self.to_python(data) | ||
| except ValidationError: | ||
| pass |
There was a problem hiding this comment.
Test coverage is missing for this branch. You might need to add some initial test coverage for has_changed() in a separate commit.
There was a problem hiding this comment.
added testcase for existing implementation
timgraham
changed the title
https://code.djangoproject.com/ticket/28950