Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the allow_sliced_subqueries database feature to allow_sliced_subqueries_with_in. #9669

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Feb 6, 2018

After 0899d58, this database feature is false only on MySQL, which doesn't support sliced subqueries only with IN/ALL/ANY/SOME.

@charettes
Copy link
Member

Thanks for that, I was wondering what was the purpose of this flag in #9660. I guess it could be worth mentioning it in the release notes?

Copy link
Member

@timgraham timgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found sqlserver_ado/features.py: allow_sliced_subqueries = False -- did you confirm it has the same meaning there?

@@ -230,6 +230,9 @@ Database backend API
feature are changed from :exc:`NotImplementedError` to
:exc:`django.db.NotSupportedError`.

* Renamed ``allow_sliced_subqueries`` database feature flag to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the

…subqueries_with_in.

After 0899d58 this database feature is
false only on MySQL which doesn't support sliced subqueries only with
IN/ALL/ANY/SOME.
@felixxm
Copy link
Member Author

felixxm commented Feb 6, 2018

@charettes Agreed. I added note in the release notes.

@felixxm felixxm changed the title Renamed allow_sliced_subqueries database feature to allow_sliced_subqueries_with_in. Renamed the allow_sliced_subqueries database feature to allow_sliced_subqueries_with_in. Feb 6, 2018
@felixxm
Copy link
Member Author

felixxm commented Feb 6, 2018

@timgraham MSSQL supports OFFSET/FETCH since SQL Server 2012, without this restriction. I think it is obsolete and can be removed from this 3rd-party database backend.

@felixxm felixxm merged commit 34b52f8 into django:master Feb 7, 2018
@felixxm felixxm deleted the allow_sliced_subqueries_in branch February 7, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants