Fixed #29199 -- Fixed crash when database user password contains @ sign on Oracle. #9768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
commented
Mar 9, 2018
| return settings_dict['NAME'] | ||
|
|
||
| def _connect_string(self): | ||
| return '%s/\\"%s\\"@%s' % (self.settings_dict['USER'], self.settings_dict['PASSWORD'], self._dsn()) |
There was a problem hiding this comment.
This is the only format that works with sqlplus, but it doesn't work as a dsn argument to cx_Oracle.connect(). That's why I decided to separate the dsn() method.
shaneallgeier
approved these changes
Mar 9, 2018
timgraham
approved these changes
Mar 13, 2018
tests/backends/oracle/tests.py
Outdated
| # expected. | ||
| if 'ORA-01017' not in str(e): | ||
| self.fail('Unexpected error raised with password: %s' % e) | ||
| except Exception as e: |
There was a problem hiding this comment.
I think this is unneeded as per c9ae09a.
tests/backends/oracle/tests.py
Outdated
|
|
||
|
|
||
| @unittest.skipUnless(connection.vendor == 'oracle', 'Oracle tests') | ||
| class PasswordWithAtSignTest(TransactionTestCase): |
There was a problem hiding this comment.
Can you use a more generic class name so it could be used for other tests? (may be fine to rename and reuse HiddenNoDataFoundExceptionTest?)
…gn on Oracle. Thanks Tim Graham for the review.
|
@timgraham @shaneallgeier Thanks for reviews. I updated tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/29199