Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_overrides has been moved to the meta class in django-filter 0.15 #117

Merged
merged 2 commits into from Sep 26, 2016

Conversation

Fingel
Copy link
Contributor

@Fingel Fingel commented Sep 21, 2016

No description provided.

@coveralls
Copy link

coveralls commented Sep 21, 2016

Coverage Status

Coverage remained the same at 99.628% when pulling 78527f6 on Fingel:master into 7ec925a on djangonauts:master.

@nemesifier
Copy link
Member

Can we maintain backward compatibility with the old django-filter versions by using a try except block please?

@Fingel
Copy link
Contributor Author

Fingel commented Sep 26, 2016

Updated for backwards compatibility

@coveralls
Copy link

coveralls commented Sep 26, 2016

Coverage Status

Coverage remained the same at 99.628% when pulling 5b5bc44 on Fingel:master into 7ec925a on djangonauts:master.

@nemesifier nemesifier merged commit 7091af2 into openwisp:master Sep 26, 2016
@nemesifier
Copy link
Member

thanks @Fingel

@blueyed
Copy link
Contributor

blueyed commented Oct 10, 2016

@nemesisdesign
Can we have a new release with this fix, please?

@Fingel
Copy link
Contributor Author

Fingel commented Nov 7, 2016

Is this project abandoned? We could really use a release with this fix. django-filter 0.15 has been out for almost 2 months.

@nemesifier
Copy link
Member

No is not abandoned. Please rephrase your last comment. You want me to issue a new release?

@nemesifier
Copy link
Member

@Fingel see also #118

@Fingel
Copy link
Contributor Author

Fingel commented Nov 10, 2016

A new release would be pertinent. There is no indication in the README that this project requires django-filter <= 1.4. This means the version of this package on PyPi is essentially broken for users that haven't pinned django-filter or new users that have not seen this issue.
Thank you!

@nemesifier
Copy link
Member

@Fingel I just tried running unit tests with the latest version of django-filter (1.0) to find out the package doesn't work with it. What a bummer. See #120. I'll issue a new release anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants