Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-filter 1.0 compatibility #120

Closed
nemesifier opened this issue Nov 22, 2016 · 4 comments
Closed

django-filter 1.0 compatibility #120

nemesifier opened this issue Nov 22, 2016 · 4 comments

Comments

@nemesifier
Copy link
Member

The current version of drf-gis is not compatible with django-filter 1.0 yet.

I am not going to work on this issue unless I will need it for one of my projects, therefore, for those who do use this kind of feature, I invite you to contirbute.

@blueyed
Copy link
Contributor

blueyed commented Nov 22, 2016

What exactly does not work?
I assume it will show up in #121 due to a new build?

@nemesifier
Copy link
Member Author

@blueyed I am not following you: I was talking about django-filter 1.0, not django 1.10

@blueyed
Copy link
Contributor

blueyed commented Nov 22, 2016

I was talking about django-filter 1.0

Sure, but that gets used in Travis, isn't it?

I was wondering, since it works in our project - so it might be more an issue with the tests than the app itself?!

@nemesifier
Copy link
Member Author

@blueyed, the previous recent builds were failing. I fixed the builds by pinning specific versions of drf and django-filters (see requirements.txt and requirements-tests.txt respectively).
django-filter 1.0 breaks compatibility with previous versions so the code needs to be adjusted while maintaining backward compatibility, more information available at https://django-filter.readthedocs.io/en/develop/guide/migration.html.

blueyed added a commit to blueyed/django-rest-framework-gis that referenced this issue Nov 22, 2016
carsongee pushed a commit to Superpedestrian/django-rest-framework-gis that referenced this issue Apr 17, 2017
davidmiller4185101 added a commit to davidmiller4185101/framework-gis-django-rest that referenced this issue Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants