Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝Initial idea for docs generation #1073

Merged
merged 17 commits into from
Dec 8, 2023
Merged

📝Initial idea for docs generation #1073

merged 17 commits into from
Dec 8, 2023

Conversation

ryancheley
Copy link
Member

There's still a bit that needs to be done, but as an initial proof of concept this seems like a good start. One thing I keep running into is that if I try to move the file docs-tamplate.md into the docs directory (where I think it should go) I get an error like this:

ModuleNotFoundError: No module named 'settings'

I tried various things to get rid of this error (like using settings.configure()) but this just threw error messages about missing settings (like LOGGING_CONFIG). Each time I would try and add a new setting I would get a new error about another missing setting. Not sure what is the best way to approach something like this.

ryancheley and others added 3 commits November 18, 2023 07:22
moved the commands to a seperate script file to be called from just
@saadmk11
Copy link
Member

saadmk11 commented Dec 2, 2023

As we are using Mkdocs for documentation, we can probably checkout mkdocstrings.

This mkdocs plugin uses class/function doc strings to generate documentation. (Though I am assuming this is what we are going for here without full context, so, I might be wrong :))

@ryancheley
Copy link
Member Author

@saadmk11 mkdocstrings looks really interesting and seems to do what I was hoping to do. I’ll dig into it a bit more tomorrow. Thanks for pointing it out!

@ryancheley
Copy link
Member Author

I pushed up a change to use mkdocstrings (thanks @saadmk11 for the idea!) and I think it will work much better than the previous attempt. There's a bit of cleanup that is still needed, but am hoping to get some feedback on the attempt so far

@saadmk11
Copy link
Member

saadmk11 commented Dec 4, 2023

I pushed up a change to use mkdocstrings (thanks @saadmk11 for the idea!) and I think it will work much better than the previous attempt. There's a bit of cleanup that is still needed, but am hoping to get some feedback on the attempt so far

This looks like a great start 👍 , I think we can move all the deprecation rule docs to a single file.

docker-compose.yml Outdated Show resolved Hide resolved
@ryancheley
Copy link
Member Author

I pushed up a change to use mkdocstrings (thanks @saadmk11 for the idea!) and I think it will work much better than the previous attempt. There's a bit of cleanup that is still needed, but am hoping to get some feedback on the attempt so far

This looks like a great start 👍 , I think we can move all the deprecation rule docs to a single file.

@saadmk11 I'm not sure what you mean by moving all of the deprecation rule docs to a single file. I believe they already are. What happened to me was I initially read Description as Deprecated and I thought they were duplicative. Not sure if that's what you're referring to as well 😄

@saadmk11
Copy link
Member

saadmk11 commented Dec 5, 2023

I pushed up a change to use mkdocstrings (thanks @saadmk11 for the idea!) and I think it will work much better than the previous attempt. There's a bit of cleanup that is still needed, but am hoping to get some feedback on the attempt so far

This looks like a great start 👍 , I think we can move all the deprecation rule docs to a single file.

@saadmk11 I'm not sure what you mean by moving all of the deprecation rule docs to a single file. I believe they already are. What happened to me was I initially read Description as Deprecated and I thought they were duplicative. Not sure if that's what you're referring to as well 😄

I meant we can move all the Search Score Rules into the same docs page as they don't contain much text.
Screenshot from 2023-12-05 13-25-58

@ryancheley
Copy link
Member Author

@saadmk11 I think I've made the change you're suggesting. can you take a look?

@jefftriplett
Copy link
Contributor

This is looking good to me so far. We can always break rules into their own pages once we have the content for it. So this feels like we are landing in a good place to reference. 🎉

@saadmk11
Copy link
Member

saadmk11 commented Dec 6, 2023

@saadmk11 I think I've made the change you're suggesting. can you take a look?

Thanks for the quick updates. Will do a full review after the PR is ready for review :)

@ryancheley ryancheley marked this pull request as ready for review December 8, 2023 20:43
Copy link
Contributor

@jefftriplett jefftriplett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefftriplett jefftriplett merged commit 5e524d7 into main Dec 8, 2023
3 checks passed
@jefftriplett jefftriplett deleted the add-doc-logic-1064 branch December 8, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants