-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝Initial idea for docs generation #1073
Conversation
Potential solution for #1064
moved the commands to a seperate script file to be called from just
for more information, see https://pre-commit.ci
As we are using Mkdocs for documentation, we can probably checkout mkdocstrings. This mkdocs plugin uses class/function doc strings to generate documentation. (Though I am assuming this is what we are going for here without full context, so, I might be wrong :)) |
@saadmk11 mkdocstrings looks really interesting and seems to do what I was hoping to do. I’ll dig into it a bit more tomorrow. Thanks for pointing it out! |
I pushed up a change to use |
This looks like a great start 👍 , I think we can move all the deprecation rule docs to a single file. |
@saadmk11 I'm not sure what you mean by moving all of the deprecation rule docs to a single file. I believe they already are. What happened to me was I initially read |
I meant we can move all the Search Score Rules into the same docs page as they don't contain much text. |
@saadmk11 I think I've made the change you're suggesting. can you take a look? |
This is looking good to me so far. We can always break rules into their own pages once we have the content for it. So this feels like we are landing in a good place to reference. 🎉 |
Thanks for the quick updates. Will do a full review after the PR is ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There's still a bit that needs to be done, but as an initial proof of concept this seems like a good start. One thing I keep running into is that if I try to move the file
docs-tamplate.md
into thedocs
directory (where I think it should go) I get an error like this:I tried various things to get rid of this error (like using
settings.configure()
) but this just threw error messages about missing settings (like LOGGING_CONFIG). Each time I would try and add a new setting I would get a new error about another missing setting. Not sure what is the best way to approach something like this.