Skip to content
This repository has been archived by the owner on Feb 18, 2018. It is now read-only.

Fix icmp enetunreach bug #36

Closed
wants to merge 23 commits into from

Commits on Feb 26, 2014

  1. Configuration menu
    Copy the full SHA
    3ccaee9 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2014

  1. Add travis tests for various ruby versions, with 1.8.7 and jruby mark…

    …ed as allowed failures
    ianheggie committed Mar 21, 2014
    Configuration menu
    Copy the full SHA
    e391c27 View commit details
    Browse the repository at this point in the history
  2. Commented out jruby 18mode and 19mode till it is fixed so

    we don't repeat three copies of it freezing for 10 minutes
    ianheggie committed Mar 21, 2014
    Configuration menu
    Copy the full SHA
    1c0a6f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2014

  1. Merge pull request djberg96#29 from ianheggie/add_travis_tests

    Add travis tests for various ruby versions, with 1.8.7 and jruby marked ...
    djberg96 committed Mar 22, 2014
    Configuration menu
    Copy the full SHA
    55d00af View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2014

  1. Add ICMP tests to travis-ci (refactored exclusions to work

    with rvmsudo);
    Drop ruby 1.8.7 test;
    Fix ping of 192.168.0.1 to use 127.0.0.1 instead;
    Move handling of EXCLUDE_ICMP_TEST to the same place as other excludes;
    ianheggie committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    9a0748f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c59c70 View commit details
    Browse the repository at this point in the history
  3. Merge pull request djberg96#31 from ianheggie/add_icmp_tests_to_travis

    Add icmp tests to travis, drop ruby 1.8.7, note known issues discovered in testing
    djberg96 committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    c699a8a View commit details
    Browse the repository at this point in the history
  4. Fixed timeouts in Net::Ping::External

    Using Timeout.timeout with Open3 is not an option with Ruby > 1.9.3
    (see https://bugs.ruby-lang.org/issues/5487). Implemented a workaround
    based on the code at https://gist.github.com/lpar/1032297
    bcandrea committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    77fd65a View commit details
    Browse the repository at this point in the history
  5. Update travis.yml to trigger CI run

    This update should trigger a Travis CI build on different Rubies.
    bcandrea committed Mar 26, 2014
    Configuration menu
    Copy the full SHA
    6ae1b88 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2014

  1. Merge pull request djberg96#32 from bcandrea/develop

    Fixed timeouts in Net::Ping::External
    djberg96 committed Mar 27, 2014
    Configuration menu
    Copy the full SHA
    61cd0a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb83bc9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from djberg96/master

    Merge back changes from djberg96
    bcandrea committed Mar 27, 2014
    Configuration menu
    Copy the full SHA
    c034875 View commit details
    Browse the repository at this point in the history
  4. Fix a typo in the Net::Ping::External test

    This typo had the effect of setting the expected
    ping duration to 5.5s instead of 1.5s. Since in Windows
    the defaul ping timeout is 4s, the test always passed.
    bcandrea committed Mar 27, 2014
    Configuration menu
    Copy the full SHA
    ef80ced View commit details
    Browse the repository at this point in the history
  5. Avoid implementing timeout on Windows

    The -w option of ping on Windows has the same effect
    of an external timeout.
    bcandrea committed Mar 27, 2014
    Configuration menu
    Copy the full SHA
    9fe37ec View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c805658 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2014

  1. Merge pull request djberg96#33 from bcandrea/develop

    Fix a typo in the unit test for Net::Ping::External and change the implementation for Windows
    djberg96 committed Mar 28, 2014
    1 Configuration menu
    Copy the full SHA
    a4ae2bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    666474e View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2014

  1. Squashed 0944d8a (check_timeout) into one commit:

    coSimplify and expand tests, adding tests for:
    * timeout conditions
    * unreachable hosts and routes
    * open and unused ports
    
    Added test/setup_ubuntu.bash to setup unreachable host, route,
    and confirm we can still use telstra.com as a black hole
    for pings and tests for ports 7, 22 and 1001
    
    Refactored tests to line up with existing example in external
    
    Add extra rvm versions;
    Add IGNORE_HTTP_PING_DOES_NOT_WAITS_FOR_RESPONSE_BUG and
    IGNORE_HTTP_PING_DOES_NOT_TIMEOUT_BUG to test those bugs with
    failure allowed;
    
    Reorganise .travis.yml to make intent clearer
    
    Speed up timeout tests
    
    Give more details on failing tests
    ianheggie committed Mar 30, 2014
    Configuration menu
    Copy the full SHA
    9fdfc69 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2014

  1. Change UNREACHABLE_HOST to using a script to try and find an unreacha…

    …ble host (using iptables doesn't work for host unreachable);
    
    Don't enforce that icmp pings have to wait if they discover network unreachable early;
    ianheggie committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    8453f54 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/master'

    Conflicts: (resolved in favour of upstream changes):
    	README
    	lib/net/ping/external.rb
    	test/test_net_ping_external.rb
    ianheggie committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    f6bd725 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' (and upstream) into extra_timeout_and_unreachab…

    …le_tests
    
    Conflicts:
    	test/test_net_ping_external.rb
    ianheggie committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    a599135 View commit details
    Browse the repository at this point in the history
  4. Fix ICMP ENETUNREACH Bug

    ianheggie committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    8b4eb6f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d5e7514 View commit details
    Browse the repository at this point in the history