Add tide integration #347
Merged
Add tide integration #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
tide
branch
2 times, most recently
from
70df813
to
7a8b394
Compare
|
Thanks for doing the work on this, will be happy to accept this!
|
djc
reviewed
Jul 13, 2020
|
(Never mind, fixed this myself since it was easy.) |
|
Thanks! |
|
It's on crates.io now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for Askama! I'm excited to use this with the tide web framework, so I wrote a little integration.
I had a question about the fallibility of
render()(not render_into) — I tried to figure out how to write a test of the Err variant, and I couldn't figure out what the failure conditions would be, as it's astd::fmt::Write::write_fmtinto a String. Is it fairly safe to just unwrap the Result returned by render? If so, that would let us useInto<Body>which would be preferable. If not, how can I provide inputs that fail in order to test both paths?Thanks again, and let me know if there are changes I can make to improve this PR!