-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tide integration #347
Add tide integration #347
Conversation
70df813
to
7a8b394
Compare
Thanks for doing the work on this, will be happy to accept this!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some little things. Let me know if you're okay fixing these up!
(Never mind, fixed this myself since it was easy.) |
Thanks! |
It's on crates.io now! |
Hi, and thanks for Askama! I'm excited to use this with the tide web framework, so I wrote a little integration.
I had a question about the fallibility of
render()
(not render_into) — I tried to figure out how to write a test of the Err variant, and I couldn't figure out what the failure conditions would be, as it's astd::fmt::Write::write_fmt
into a String. Is it fairly safe to just unwrap the Result returned by render? If so, that would let us useInto<Body>
which would be preferable. If not, how can I provide inputs that fail in order to test both paths?Thanks again, and let me know if there are changes I can make to improve this PR!