Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use syn::Error::to_compile_error and add trybuild ui test #374

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

msrd0
Copy link
Contributor

@msrd0 msrd0 commented Nov 2, 2020

This PR only contains one trybuild ui test, others can be added later if desired by putting more files into the tests/ui/ folder.

Fixes #368

Copy link
Owner

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@msrd0
Copy link
Contributor Author

msrd0 commented Nov 2, 2020

Looks like the test requires an operating system that uses forward slashes, do you want me to disable the test on windows?

@djc
Copy link
Owner

djc commented Nov 2, 2020

Yeah, that seems like a fine solution for this.

@djc djc merged commit f23162a into djc:main Nov 2, 2020
@msrd0 msrd0 deleted the use-syn-to-compile-error branch November 4, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using compile_error! instead of panicking
2 participants