Implement destructoring structs on "let" and "for" statement target #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
force-pushed
the
pr-destructoring-structs
branch
from
465f69c
to
d709843
Compare
|
Rebased on #506. |
Kijewski
changed the title
Kijewski
force-pushed
the
pr-destructoring-structs
branch
from
d709843
to
51e39ad
Compare
This PR implements the destructoring of structs on the lhs of "let" and "for" statements.
Kijewski
force-pushed
the
pr-destructoring-structs
branch
from
51e39ad
to
cfacc7e
Compare
djc
approved these changes
Jul 5, 2021
|
Thanks again! Do you have any more short-term plans for adding stuff? |
|
You're welcome! All my short-term plans are fulfilled. In a week (or most likely later) I'd like to unify parser.rs' match_variant() and target(), so that I think #513 (Better error messages using cuts) would be a nice-to-have, too, but right now I don't have the time to test it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #506.