Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded 0-RTT testing, assorted fixes #194

Merged
merged 6 commits into from
Jan 12, 2019
Merged

Expanded 0-RTT testing, assorted fixes #194

merged 6 commits into from
Jan 12, 2019

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Jan 12, 2019

This tests the behavior tonight's rustls fixes corrected.

@Ralith
Copy link
Collaborator Author

Ralith commented Jan 12, 2019

Travis failure looks spurious.

djc
djc previously approved these changes Jan 12, 2019
@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ec794de). Click here to learn what that means.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #194   +/-   ##
=========================================
  Coverage          ?   74.07%           
=========================================
  Files             ?       23           
  Lines             ?     5864           
  Branches          ?        0           
=========================================
  Hits              ?     4344           
  Misses            ?     1520           
  Partials          ?        0
Impacted Files Coverage Δ
quinn-proto/src/endpoint.rs 76.86% <ø> (ø)
quinn-proto/src/stream.rs 88.1% <100%> (ø)
quinn-proto/src/connection.rs 72.7% <38.09%> (ø)
quinn-proto/src/tests.rs 91.08% <96.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec794de...9ffd653. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #194 into master will increase coverage by 3.84%.
The diff coverage is 76.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   73.85%   77.69%   +3.84%     
==========================================
  Files          23       23              
  Lines        5813     6744     +931     
==========================================
+ Hits         4293     5240     +947     
+ Misses       1520     1504      -16
Impacted Files Coverage Δ
quinn-proto/src/endpoint.rs 81.69% <ø> (+4.38%) ⬆️
quinn-proto/src/stream.rs 88.1% <100%> (+0.1%) ⬆️
quinn-proto/src/connection.rs 78.99% <47.82%> (+7.01%) ⬆️
quinn-proto/src/tests.rs 91.08% <96.77%> (+0.3%) ⬆️
quinn-proto/src/lib.rs 50% <0%> (+2.08%) ⬆️
quinn-proto/src/packet.rs 88.41% <0%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec794de...9ffd653. Read the comment docs.

@Ralith
Copy link
Collaborator Author

Ralith commented Jan 12, 2019

Tweaked the read_tls condition.

@Ralith Ralith merged commit b58d1e8 into master Jan 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixes branch January 12, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants