Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted fixes #199

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Assorted fixes #199

merged 5 commits into from
Jan 16, 2019

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Jan 16, 2019

I'll try to build some actual flow control tests later, but I'm pretty sure 04427b0 fixes a serious bug (and makes things a little cleaner anyway).

@Ralith
Don't forget about new streams if more than one arises at once
1de8ce9
@Ralith
Don't let Handshake packets validate 1-RTT migration
5d4117c
@Ralith
Detect another FINAL_OFFSET_ERROR case
54091b1
@Ralith
Fix flow control leak on RESET_STREAM and process resets eagerly
04427b0 
We weren't issuing additional flow control credit to account for the
bytes that the peer thinks it's sent but which we haven't read yet. As
part of this change, we've gone from keeping data on reset streams
around until it's read and issuing credit as that proceeds to
discarding data on reset streams immediately and issuing credit for
all outstanding data on the stream, whether or not we've received and
buffered it.
@Ralith
Factor out common stream read code
78ce1dd
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #199 into master will increase coverage by <.01%.
The diff coverage is 78.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #199      +/-   ##
=========================================
+ Coverage    74.2%   74.2%   +<.01%     
=========================================
  Files          24      24              
  Lines        5893    5905      +12     
=========================================
+ Hits         4373    4382       +9     
- Misses       1520    1523       +3
Impacted Files Coverage Δ
quinn-proto/src/tests.rs 91.05% <ø> (-0.03%) ⬇️
quinn-proto/src/connection.rs 72.53% <70.58%> (-0.18%) ⬇️
quinn-proto/src/stream.rs 90.04% <88.88%> (+1.93%) ⬆️
quinn-proto/src/packet.rs 82.16% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31bb03...78ce1dd. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #199 into master will increase coverage by <.01%.
The diff coverage is 78.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #199      +/-   ##
=========================================
+ Coverage    74.2%   74.2%   +<.01%     
=========================================
  Files          24      24              
  Lines        5893    5905      +12     
=========================================
+ Hits         4373    4382       +9     
- Misses       1520    1523       +3
Impacted Files Coverage Δ
quinn-proto/src/tests.rs 91.05% <ø> (-0.03%) ⬇️
quinn-proto/src/connection.rs 72.53% <70.58%> (-0.18%) ⬇️
quinn-proto/src/stream.rs 90.04% <88.88%> (+1.93%) ⬆️
quinn-proto/src/packet.rs 82.16% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31bb03...78ce1dd. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 16, 2019 •
edited
Loading

Codecov Report

Merging #199 into master will increase coverage by <.01%.
The diff coverage is 78.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #199      +/-   ##
=========================================
+ Coverage    74.2%   74.2%   +<.01%     
=========================================
  Files          24      24              
  Lines        5893    5905      +12     
=========================================
+ Hits         4373    4382       +9     
- Misses       1520    1523       +3
Impacted Files Coverage Δ
quinn-proto/src/tests.rs 91.05% <ø> (-0.03%) ⬇️
quinn-proto/src/connection.rs 72.53% <70.58%> (-0.18%) ⬇️
quinn-proto/src/stream.rs 90.04% <88.88%> (+1.93%) ⬆️
quinn-proto/src/packet.rs 82.16% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31bb03...78ce1dd. Read the comment docs.

@djc djc merged commit e4c51ba into master Jan 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixes branch January 16, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ralith @djc