Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated html export to org v8 standards #480

Merged
merged 1 commit into from
Oct 11, 2014
Merged

Conversation

jonEbird
Copy link

@jonEbird jonEbird commented Oct 3, 2014

Replaced use of org-export-string with org-export-string-as to match
updated org coding standards.

This specifically addresses issue #391

Replaced use of org-export-string with org-export-string-as to match
updated org coding standards.

This specifically addresses issue djcb#391
@djcb
Copy link
Owner

djcb commented Oct 9, 2014

Looks good, but how does this affect users that do not have org 8.x yet?

@jonEbird
Copy link
Author

jonEbird commented Oct 9, 2014

All my machines are up to date with org version 8.x, so it's harder for me to test an older version of org. I did look at the git log for org-mode and see that the new function I'm using was introduced with version 8 (commit 8dd2bfc2) Perhaps I can rework the patch to conditional select which method to use with a preference on the newer function if available?

@djcb
Copy link
Owner

djcb commented Oct 9, 2014

What want to avoid is that the org-code suddenly starts breaking for some users using older org versions... Probably the best would be to have some mu4e-org-old.el and mu4e-org-new.el (with better names!) and then have mu4e-org.el automatically load the one based on the org-version.

@jonEbird
Copy link
Author

jonEbird commented Oct 9, 2014

I suppose that would help keep the code simpler in each file but I also wonder if the only conditional place needed is in the org~mu4e-mime-convert-to-html function.

What about keeping the current file named as it already is in "org-mu4e.el" and have the newer one called "org-mu4e-ox.el" or "ox-mu4e.el"? The updated exporting system in v8 of org-mode introduced lisp/ox.el as the core, generic org exporter (ox), so it would imply that it's using the updated exporter.

@jschwab
Copy link
Contributor

jschwab commented Oct 9, 2014

A question relevant to this and other issues is "what versions of emacs does mu/mu4e officially support?". Is this written anywhere?

djcb added a commit that referenced this pull request Oct 11, 2014
mu4e: updated html export to org v8 standards
@djcb djcb merged commit bd334a5 into djcb:master Oct 11, 2014
@djcb
Copy link
Owner

djcb commented Oct 11, 2014

Merged -- thanks! I have split off a 'legacy' version into org-old-mu4e.el, so we can depend on org 8.x org-mu4e.el.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants