Disable broken effect batching #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batching of compatible effects (and in particular, multiple instances of the same effect) is currently broken due to the inability for a particle to tell which effect it's associated with, and therefore which `GpuSpawnerParams` struct it should index. To prevent batching to trigger, set the minimum buffer capacity to 1 particle, which effectively means each effect will get a dedicated GPU buffer that just fits it, preventing another effect from using the same buffer, and effectively disabling batching.o Bug: #73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batching of compatible effects (and in particular, multiple instances of the same effect) is currently broken due to the inability for a particle to tell which effect it's associated with, and therefore which
GpuSpawnerParamsstruct it should index.To prevent batching to trigger, set the minimum buffer capacity to 1 particle, which effectively means each effect will get a dedicated GPU buffer that just fits it, preventing another effect from using the same buffer, and effectively disabling batching.o
Bug: #73