Bug fix: Create Token button disabled

[tallpauley]

Fixes #205

Weirdly, catch() w/ no arguments doesn't resolve the promise, it rejects it. So I had a token w/out access to auth/token/create-orphan, and while the button was enabled, it was disabled again in the catch block.

This fixes the issue. @djenriquez have you experienced this behavior? Weirdly, just putting the empty anonymous function as the catch argument fixed it. I want to make sure I'm not crazy here, not a JS guru at all :)

[tallpauley]

This is the policy I was using to test:

path "auth/token/create" {
  capabilities = ["update"]
}

path "sys/policy" {
  capabilities = ["read"]
}

path "sys/auth" {
  capabilities = ["read"]
}

path "sys/mounts" {
  capabilities = ["read"]
}

[djenriquez]

Interesting, I can't explain this behavior. @Lucretius thoughts?

[Lucretius]

So, from the Promise spec, catch just internally uses a then call with the error state of the promise returned. Without passing a function to the catch it apparently just forwards the initial error along. However, if you pass a function, even though its empty, it will swallow the thrown error and return with a resolved undefined

[tallpauley]

Thanks @Lucretius. Since the return value isn't important here, does this change look ok?

[Lucretius]

Yes it looks fine - the return value will be undefined but if its not being used anywhere it doesn't matter. it will sucessfully swallow the error now as you are seeing. 👍