Use internal calibration coefficients if available #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h between pyspectral and AMI brightness temperature conversion
djhoese
requested changes
Oct 8, 2019
There was a problem hiding this comment.
Thank you!!!!
There are a couple small things that I'd like updated and mentioned in comments. Otherwise the one big thing is: Could you move the IR calibration to a separate method to simplify the code? Could you also then update the tests to make sure they have the appropriate attributes and that both IR calibration modes are tested.
…h between pyspectral and AMI brightness temperature conversion
…feature-ami-reader
djhoese
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the internal calibration coefficients (slope and offset) contained in each netCDF4 file as a pair of attributes. If these coefficients are invalid then we fall back onto the pre-defined coefficient set.
For the example images I've tested, the internal and pre-defined coefficients are identical, so this change has no effect. But this might change in the future.