Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base include directory to DJIOSDFConfig.cmake #487

Closed

Conversation

jcmonteiro
Copy link

Currently the generated DJIOSDKConfig.cmake does not add the base include directory to the DJIOSDK_INCLUDE_DIRS variable. This causes some programs which depend on the djiosdk to fail to compile, such as the DJI Onboard SDK ROS.

If the base include directory is not added to DJIOSDK_INCLUDE_DIRS, one cannot include headers as

#include <djiosdk/dji_vehicle.hpp>

Include is only possible via

#include <dji_vehicle.hpp>

In some cases, this bug might go unnoticed if one installs the djiosdk in a directory that is usually included by some other dependency, such as /usr/include.

I changed the DJIOSDKConfig.cmake to allow both include possibilities

#include <djiosdk/dji_vehicle.hpp>
#include <dji_vehicle.hpp>

to avoid compatibility issues.

@DJI-Jerry DJI-Jerry closed this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants