add base include directory to DJIOSDFConfig.cmake #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generated
DJIOSDKConfig.cmake
does not add the base include directory to theDJIOSDK_INCLUDE_DIRS
variable. This causes some programs which depend on thedjiosdk
to fail to compile, such as the DJI Onboard SDK ROS.If the base include directory is not added to
DJIOSDK_INCLUDE_DIRS
, one cannot include headers asInclude is only possible via
In some cases, this bug might go unnoticed if one installs the
djiosdk
in a directory that is usually included by some other dependency, such as/usr/include
.I changed the
DJIOSDKConfig.cmake
to allow both include possibilitiesto avoid compatibility issues.