Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Make sure that fullscreen clients are on correct layer #491

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Make sure that fullscreen clients are on correct layer #491

merged 2 commits into from
Sep 30, 2023

Conversation

fbushstone
Copy link
Contributor

Closes Issue 487.
Should actually fix the issue rather than just bandaid over it like by earlier PR.

Clients were that had fullscreen enabled were reparented to the floating layer rather than the fullscreen layer. This should allow clients that have fullscreen enabled to be set to the correct layer.

@fbushstone
Copy link
Contributor Author

fbushstone commented Sep 29, 2023

This change could also be implemented by changing layers[c->isfloating ? LyrFloat : LyrTile] to layers[c->isfullscreen ? LyrFS : c->isfloating ? LyrFloat : LyrTile] in line 2031. The earlier commit showcases another way to go about this, but I think this method should be a bit cleaner.

@sevz17 sevz17 merged commit f695674 into djpohly:main Sep 30, 2023
@sevz17
Copy link
Collaborator

sevz17 commented Sep 30, 2023

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that background does not spawn in front of fullscreen clients
2 participants