Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to PSR2 and simplify accessor #2

Merged
merged 1 commit into from
May 18, 2019

Conversation

niladam
Copy link
Contributor

@niladam niladam commented May 18, 2019

I basically, applied some simple styling to this and i refactored the getUrlAttribute so that it's easier to read and a little bit simplified it :)

I basically, applied some simple styling to this and i refactored the `getUrlAttribute` so that it's easier to read and a little bit simplified it :)
@niladam
Copy link
Contributor Author

niladam commented May 18, 2019

I think the entire codebase should be refactored to PSR2 so that it matches Laravel's style. You could do this via php-cs-fixer. I think this might get you on the right path as i see you're using PhpStorm.

@djurovicigoor djurovicigoor merged commit 694f7bd into djurovicigoor:master May 18, 2019
@djurovicigoor
Copy link
Owner

Codebase should be refactored to PSR2 to match Laravel's code styles definitely but I'm used to having this kind of code style. It's more readable for me. In some of the next versions, I will refactor codebase to PSR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants