Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test restructure #105

Closed

Conversation

KevinOnFrontEnd
Copy link
Contributor

Keeping this as a Draft for a few days until the proposed improvements are completed. #this is not completed just yet#.

  • Introduced xUnit
  • Introduced a test base class that instantiates the correct dependencies e.g. http rpc client to the was rpc client.
  • Main improvement is the tests will read from secrets/environment variables - enabling each developer to have their own settings without checking in changes to where their certs/keys are stored. This will help massively when running the tests in a GitHub action against a real chia daemon.
  • RPC clients are got from the test base class - which no longer need to be instantiated in a test class. These will be instantiated when the test server starts - and will be driven from a configure variable.

Notable changes

@dkackman
Copy link
Owner

dkackman commented Aug 7, 2023

I'm down with this approach. Looks like a great direction.

Since I'm done with the 1.8.2 updates, let me know how I can help here.

@KevinOnFrontEnd
Copy link
Contributor Author

Shall we split up the remaining proxies & the tests and work through them one by one?

It would involve updating the ChiaDotNetFixture for both wss/https client by adding the proxies to the services & converting the test classes one by one & adding the path to the cert/uri/key to the appsettings (though these are overrideable using secrets).

I'm currently working on the walletproxy & tests.

@dkackman
Copy link
Owner

dkackman commented Aug 7, 2023

Makes sense. Let me know when you're ready to move out of draft mode and then I'll merge and jump in.

@dkackman
Copy link
Owner

dkackman commented Aug 7, 2023

also - i introduced some conflicts in the tests because i changed some method signatures. feel free to comment out if needed.

@KevinOnFrontEnd
Copy link
Contributor Author

No worries, i'll rebase and resolve the conflicts today and mark it for ready a little later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants