-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add query param #24
Conversation
Hi @yamyn . Sorry for a very late reply, I missed the notification. I like the changes. Can you bump the minor version in |
@dkatavic, Yes, sure. |
@dkatavic, Done) |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "onedrive-api", | |||
"version": "0.3.4", | |||
"version": "0.4.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "0.4.0"
, after updating minor version we are resetting patch version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, you can merge the changes. Thanks for the contribution :)
@yamyn Thanks for the contribution, I have merged the changes |
Hi)
I use this simple and at the same time useful module constantly, but I constantly lack the functionality to introduce filtering and sorting methods, could you accept a small change that does not affect your product and improves functionality.