Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add query param #24

Merged
merged 6 commits into from
Sep 20, 2020
Merged

Conversation

yamyn
Copy link
Contributor

@yamyn yamyn commented Jul 9, 2020

Hi)
I use this simple and at the same time useful module constantly, but I constantly lack the functionality to introduce filtering and sorting methods, could you accept a small change that does not affect your product and improves functionality.

@dkatavic
Copy link
Owner

Hi @yamyn . Sorry for a very late reply, I missed the notification.

I like the changes. Can you bump the minor version in package.json to make sure that deploy pipeline publishes the new package?

@yamyn
Copy link
Contributor Author

yamyn commented Aug 13, 2020

@dkatavic, Yes, sure.

@yamyn
Copy link
Contributor Author

yamyn commented Aug 13, 2020

@dkatavic, Done)

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "onedrive-api",
"version": "0.3.4",
"version": "0.4.5",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "0.4.0", after updating minor version we are resetting patch version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood

Copy link
Owner

@dkatavic dkatavic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, you can merge the changes. Thanks for the contribution :)

@dkatavic dkatavic merged commit 3a8a064 into dkatavic:master Sep 20, 2020
@dkatavic
Copy link
Owner

@yamyn Thanks for the contribution, I have merged the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants