Skip to content

Commit

Permalink
new update to CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
dkesada committed Jun 11, 2020
1 parent 50bca51 commit 34f79c3
Showing 1 changed file with 5 additions and 18 deletions.
23 changes: 5 additions & 18 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,14 @@
## Resubmission
This is a resubmission. In this version I have:

* Fixed the dependency on R (>= 3.5.0) rather than R (>= 3.6.0). Check results on r-oldrel-osx-x86_64 failed because it wasn't allowed to install the package for a version prior to 3.6.0. This was due to the package visualization tool depending on grDevices (>= 3.6.0). I made an alternative that runs on grDevices (>= 3.5.0)
## Update
This is a package update from version 0.3.4 to 0.4.5. In this version, I have fixed a number of bugs and added new backwards campatible functionality.

## Test environments
* local OS X install, R 3.6.3
* Windows 10 (x64), R 3.6.3 (local)
* Ubuntu 16.04 (x64), R 3.6.3 (local)
* Windows 10 (x64), R 4.0.1 (local)
* Ubuntu 16.04 (x64), R 4.0.1 (local)
* Rhub
* win-builder (devel, release and oldrelease)

## R CMD check results
0 ERRORs | 0 WARNINGs | 2 NOTEs

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'David Quesada <dkesada@gmail.com>'
Days since last update: 4

* checking dependencies in R code ... NOTE (win_oldrelease)
Missing or unexported object: 'grDevices::hcl.colors'

### Comments
The function 'grDevices::hcl.colors' was added in 'grDevices' version 3.6.0. In order to make the package compatible with R versions (>= 3.5.0) and not get an error, I added a fix for versions prior to 3.6.0 using a different palette. This function is now never called if the 'grDevices' package is not (>= 3.6.0).
0 ERRORs | 0 WARNINGs | 0 NOTEs

## Downstream dependencies
There are no downstream dependencies

0 comments on commit 34f79c3

Please sign in to comment.