Added css classes for contao 4 compatibility #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Instead of changing the CSS of mmenu, you could also replace all |
|
But I think updating the CSS is fine, since there won't be any update to mmenu due to licensing anyway anymore, right @dklemmt ? |
|
According to #20 just changing the CSS is not enough. mmenu needs to recognize the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contao changed the markup in version 4 for the navigation:
"The navigation menus are now using <strong> instead of <span> to highlight the active menu item."
This fix adds to all classes with span an additional css class tag for <span>.