Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unlock for Contao 4 #18

Merged
merged 1 commit into from Jul 4, 2017
Merged

unlock for Contao 4 #18

merged 1 commit into from Jul 4, 2017

Conversation

fritzmg
Copy link
Collaborator

@fritzmg fritzmg commented Jun 20, 2017

As far as I have tested it, this extension works fine in Contao 4.

@dklemmt dklemmt merged commit a2efe80 into dklemmt:master Jul 4, 2017
@fritzmg
Copy link
Collaborator Author

fritzmg commented Jul 4, 2017

There is one issue though: Contao 4 uses <strong> instead of <span> for the active element now. But mmenu requires <span>.

@dklemmt
Copy link
Owner

dklemmt commented Jul 4, 2017

oh ok I merged the pull request into master but won't do any Release yet due to this issue. I don't work much with Contao lately and don't know Contao 4 at all. If you like I can add you as a collaborator to the repository :)

@fritzmg
Copy link
Collaborator Author

fritzmg commented Jul 4, 2017

Hm ok :). I won't have much time for it either, but it couldn't hurt.

@Jaaaan
Copy link

Jaaaan commented Jul 4, 2017

Maybe #15 ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants