Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type restriction support for DBpedia Spotlight #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aleSuglia
Copy link

Hi to all,

I've noticed that you haven't considered the possibility to allow the user to specify type restrictions as it is reported in the official DBpedia Spotlight documentation. For this reason, I've decided to contribute to this project by adding the types parameter to the HTTP request that is used to annotate the text using the DBpedia Spotlight service.

I hope that this pull request is appreciated.

Best regards,
Alessandro

Added support for the 'types' parameter in order to restrict annotations specific types.
@ziorufus
Copy link
Contributor

Dear Alessandro,
thank you for your contribution. We are moving some classes (such as the one you patched) to a new project which goal is to become a collection of CoreNLP wrappers made in our institution (FBK). You can see that the classes you modified are already included into the fcw-linking Maven module.
If you agree, we'll pull your patch it into that module (by acknowledging you in the commit message). Or, as an alternative, you can ask for a pull request on the new project and I'll accept it immediately.

Best,
Alessio

@aleSuglia
Copy link
Author

It's a pleasure for me to add new features to your well-structured framework. I will be pleased to add my patch to your new project. I'll clone it in the afternoon and I'll apply the same patch to it as well.

Best regards,
Alessandro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants