Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkstyle configuration and adjust formatting #1187

Closed
reckart opened this issue Feb 25, 2018 · 0 comments
Closed

Add checkstyle configuration and adjust formatting #1187

reckart opened this issue Feb 25, 2018 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request
Milestone
1.9.1

Comments

@reckart
Copy link
Member

reckart commented Feb 25, 2018

To facilitate contributions from people not using Eclipse, it seems to be a good idea to add a checkstyle configuration and adjust formatting.
@reckart reckart added the ⭐️ Enhancement New feature or request label Feb 25, 2018
@reckart reckart added this to the 1.9.1 milestone Feb 25, 2018
@reckart reckart self-assigned this Feb 25, 2018
@reckart reckart closed this as completed Feb 25, 2018
reckart added a commit that referenced this issue Feb 25, 2018
@reckart
#1187 - Add checkstyle configuration and adjust formatting
b9d1ac5 
- Added checkstyle configuration
reckart added a commit that referenced this issue Feb 25, 2018
@reckart
#1187 - Add checkstyle configuration and adjust formatting
277d7a8 
- Fixed checkstyle issues
- Added some FIXMEs to investigate later
- Replaced some explicit closing of resources with try-with-resources
- Added suppressions for generated code
reckart added a commit that referenced this issue Mar 10, 2018
@reckart
Merge branch '1.9.x'
09d82b3 
* 1.9.x:
  #1188 - NullPointerException when reading CoNLL 2012 (via PR #1189)
  #882 - License headers should not be JavaDoc comments
  #882 - License headers should not be JavaDoc comments
  #1187 - Add checkstyle configuration and adjust formatting
  #1187 - Add checkstyle configuration and adjust formatting

# Conflicts:
#	dkpro-core-gpl/pom.xml
reckart added a commit that referenced this issue Mar 10, 2018
@reckart
Merge branch 'master' into 2.0.x
ebf872e 
* master:
  #1188 - NullPointerException when reading CoNLL 2012 (via PR #1189)
  #1188 - NullPointerException when reading CoNLL 2012 (via PR #1189)
  #882 - License headers should not be JavaDoc comments
  #882 - License headers should not be JavaDoc comments
  #1187 - Add checkstyle configuration and adjust formatting
  #1187 - Add checkstyle configuration and adjust formatting
  #1174 - Update dependencies for 1.9.1
  #1184 - Support merging CAS type system with external type system in XmiReader
  #1186 - Subcategorization mapping does not work for event annotation
  #1185 - Allow trailing spaces in brat files
  #1184 - Support merging CAS type system with external type system in XmiReader

# Conflicts:
#	dkpro-core-api-coref-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/coref/type/CoreferenceChain.java
#	dkpro-core-api-coref-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/coref/type/CoreferenceChain_Type.java
#	dkpro-core-api-coref-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/coref/type/CoreferenceLink.java
#	dkpro-core-api-coref-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/coref/type/CoreferenceLink_Type.java
#	dkpro-core-api-metadata-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/metadata/type/DocumentMetaData.java
#	dkpro-core-api-metadata-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/metadata/type/DocumentMetaData_Type.java
#	dkpro-core-api-parameter-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/parameter/AnnotationChecker.java
#	dkpro-core-api-segmentation-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/segmentation/type/Compound.java
#	dkpro-core-api-segmentation-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/segmentation/type/Compound_Type.java
#	dkpro-core-api-segmentation-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/segmentation/type/Token.java
#	dkpro-core-api-segmentation-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/api/segmentation/type/Token_Type.java
#	dkpro-core-corenlp-gpl/src/test/java/de/tudarmstadt/ukp/dkpro/core/corenlp/CoreNlpCoreferenceResolverTest.java
#	dkpro-core-gpl/pom.xml
#	dkpro-core-io-bincas-asl/src/main/java/de/tudarmstadt/ukp/dkpro/core/io/bincas/BinaryCasReader.java
#	dkpro-core-stanfordnlp-gpl/src/test/java/de/tudarmstadt/ukp/dkpro/core/stanfordnlp/StanfordCoreferenceResolverTest.java
reckart added a commit that referenced this issue Mar 16, 2018
@reckart
#1187 - Add checkstyle configuration and adjust formatting
9ba76bf 
- Fixed formatting.
reckart added a commit that referenced this issue Mar 17, 2018
@reckart
#1187 - Add checkstyle configuration and adjust formatting
c2099ef 
- Added suppression for generated types.
reckart added a commit that referenced this issue Mar 17, 2018
@reckart
#1187 - Add checkstyle configuration and adjust formatting
cd5d8aa 
- Fixed formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request
Projects
None yet
Milestone
1.9.1
Development

No branches or pull requests
1 participant
@reckart