Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate 'PerformanceTest' to be a real integration test #180

Closed
mawiesne opened this issue Jul 16, 2018 · 1 comment
Closed

Migrate 'PerformanceTest' to be a real integration test #180

mawiesne opened this issue Jul 16, 2018 · 1 comment
Assignees
@mawiesne
Labels
🆕Enhancement test
Milestone
1.2.0

Comments

@mawiesne
Copy link
Contributor

In the API-module we find a class PerformanceTest which currently has this TODO:

// TODO Shall this call here also work against a MySQL backend? Seems this should be put into a real Integration Test.

So this should be moved to src/it/java in the respective module. It should then be triggered via the maven-failsafe plugin against one or more site-specific MySQL integration profiles, e.g. UKP or HHN.
@mawiesne
Copy link
Contributor Author

Also relevant: PerformanceTestPageIterator, thus it should also be moved into the IT setup.

@mawiesne mawiesne self-assigned this Jul 17, 2018
@mawiesne mawiesne added this to the 1.2.0 milestone Jul 17, 2018
@mawiesne mawiesne mentioned this issue Jul 17, 2018
Closed
4 tasks
mawiesne added a commit that referenced this issue Aug 3, 2018
@mawiesne
#180 - Migrate 'PerformanceTest' to be a real integration test
c94d592 
- Adds two different site-specific Maven profiles: `mysql-ukp` and `mysql-hhn`
- Adds Maven configuration for IT-setup (via maven-failsafe-plugin)
- Introduces the new src branch `src/it/java` in wikipedia.api module
- Moves and refactors existing code of `PerformanceTest` and `PerformanceTestPageIterator` to be executable in an IT environment
- Introduces `PerformanceIT` as a true integration test
- Adds MySQL/C3P0 dependencies in test scope to be capable of running against MySQL as if in a production setup
mawiesne added a commit that referenced this issue Aug 3, 2018
@mawiesne
#180 - Migrate 'PerformanceTest' to be a real integration test
9bb1e7e 
- Corrects integration-test profile setup. By default ITs are switched off now, as regular devs need a build that is passing
- A working mvn commandline (locally or on CI servers) should now add `-Pjacoco -Pintegration-test -Pmysql-ukp`
mawiesne added a commit that referenced this issue Aug 3, 2018
@mawiesne
#180 - Migrate 'PerformanceTest' to be a real integration test
b8ce4b4 
- Addresses minor comments by @reckart in PR #196
mawiesne added a commit that referenced this issue Aug 6, 2018
@mawiesne
#180 - Migrate 'PerformanceTest' to be a real integration test
e107ffd 
- Removes a TODO to trigger a CI build as suggested by @reckart in PR #196
reckart added a commit that referenced this issue Aug 9, 2018
@reckart
#180 - Migrate 'PerformanceTest' to be a real integration test
95e30fa 
- Changed credentials for UKP database server used during test
@reckart reckart closed this as completed in 1eb69d3 Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mawiesne mawiesne

Labels
🆕Enhancement test
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@mawiesne