Change devtools, flay, flog, reek and rubocop thresholds

* Add rubocop configuration that will exclude vendor
* Fix code to pass rubocop

.rubocop.yml

@@ -0,0 +1,6 @@
+AllCops:
+  Includes:
+    - 'Gemfile'
+  Excludes:
+    - 'Gemfile.devtools'
+    - 'vendor/**'

config/devtools.yml

@@ -2,3 +2,4 @@
 unit_test_timeout: 0.1
 fail_on_branch:
 - "master"
+- "devtools"

config/flay.yml

@@ -1,3 +1,3 @@
 ---
-threshold: 0
-total_score: 0
+threshold: 7
+total_score: 32

config/flog.yml

@@ -1,2 +1,2 @@
 ---
-threshold: 0
+threshold: 23.7

config/reek.yml

@@ -1,7 +1,8 @@
 ---
 Attribute:
   enabled: true
-  exclude: []
+  exclude:
+  - Memoizable::MethodBuilder
 BooleanParameter:
   enabled: true
   exclude: []
@@ -18,7 +19,8 @@ DataClump:
   min_clump_size: 2
 DuplicateMethodCall:
   enabled: true
-  exclude: []
+  exclude:
+  - Memoizable::Memory#fetch  # double-checked lock requires duplicate code
   max_calls: 1
   allow_calls: []
 FeatureEnvy:
@@ -40,7 +42,9 @@ LongYieldList:
   max_params: 2
 NestedIterators:
   enabled: true
-  exclude: []
+  exclude:
+  - Memoizable::Memory#fetch  # uses nested blocks
+  - Memoizable::MethodBuilder#create_memoized_method
   max_allowed_nesting: 1
   ignore_iterators: []
 NilCheck:
@@ -52,7 +56,8 @@ RepeatedConditional:
   max_ifs: 1
 TooManyInstanceVariables:
   enabled: true
-  exclude: []
+  exclude:
+  - Memoizable::MethodBuilder
   max_instance_variables: 3
 TooManyMethods:
   enabled: true
@@ -61,8 +66,9 @@ TooManyMethods:
 TooManyStatements:
   enabled: true
   exclude:
+  - Memoizable::MethodBuilder#initialize
   - each
-  max_statements: 2
+  max_statements: 5
 UncommunicativeMethodName:
   enabled: true
   exclude: []

config/rubocop.yml

@@ -1,11 +1,4 @@
-AllCops:
-  Includes:
-    - '**/*.rake'
-    - 'Gemfile'
-    - 'Gemfile.devtools'
-  Excludes:
-    - '**/vendor/**'
-    - '**/benchmarks/**'
+inherit_from: ../.rubocop.yml
 
 # Avoid parameter lists longer than five parameters.
 ParameterLists:

spec/integration/serializable_spec.rb

@@ -6,7 +6,7 @@ class Serializable
   include Memoizable
 
   def random_number
-    rand(10000)
+    rand(10_000)
   end
   memoize :random_number
 end
@@ -17,7 +17,8 @@ def random_number
   end
 
   before do
-    serializable.random_number # Call the memoized method to trigger lazy memoization
+    # Call the memoized method to trigger lazy memoization
+    serializable.random_number
   end
 
   it 'is serializable with Marshal' do

spec/unit/memoizable/memory_spec.rb

@@ -1,9 +1,11 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Memoizable::Memory do
   let(:memory) { Memoizable::Memory.new }
 
-  context "serialization" do
+  context 'serialization' do
     let(:deserialized) { Marshal.load(Marshal.dump(memory)) }
 
     it 'is serializable with Marshal' do