Kill Measurement#ok? mutations

dkubb · Sep 29, 2015 · 1db9e6c · 1db9e6c
1 parent 5881c44
commit 1db9e6c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/config/mutant.yml b/config/mutant.yml
@@ -1,7 +1,7 @@
 ---
 name: yardstick
 namespace: Yardstick
-expect_coverage: 2351/2400
+expect_coverage: 2346/2394
 ignore_subjects:
 # sometimes creates a neutral failure
 - Yardstick::Rake::Measurement#define
diff --git a/lib/yardstick/measurement.rb b/lib/yardstick/measurement.rb
@@ -34,7 +34,7 @@ def initialize(rule)
     #
     # @api public
     def ok?
-      @result.equal?(true) || skip?
+      skip? || @result
     end
 
     # Return true if the measurement was skipped

diff --git a/spec/unit/yardstick/measurement/ok_predicate_spec.rb b/spec/unit/yardstick/measurement/ok_predicate_spec.rb
@@ -18,4 +18,10 @@
 
     it { should be(false) }
   end
+
+  context 'when rule is disabled' do
+    let(:rule) { DisabledRule.new(document) }
+
+    it { should be(true) }
+  end
 end