Rearrange manual gain table calculation to match the gain-setting code more closely. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code more closely. This fixes a problem where the topmost gain would be omitted, but introduces another complication: because there is a negative step value for mixer gain in the standard gain steps, there's a possible gain value included in the table of gains that can actually never be set. Ew. I don't like just dropping the last entry either since I'm about to fix that negative mixer gain step anyway..
This only adds to the table when the gain increases. It's impossible to set gain values that result from a decrease in total gain with the current gain-setting code.
|
Ok, with that update it should return exactly the same table as the original hardcoded table, and it'll also work nicely with revised gain steps that have zeros for the final few mixer steps. |
dl8aau
added a commit
that referenced
this pull request
Apr 14, 2015
Rearrange manual gain table calculation to match the gain-setting code more closely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the topmost gain (49.6dB) would be omitted,
but introduces another complication: because there is a negative step
value for mixer gain in the standard gain steps, there's a possible
gain value included in the table of gains that can actually never
be set. Ew. I don't like just dropping the last entry either since
I'm about to fix that negative mixer gain step anyway, but if you
want to do that just make gain_table_len one shorter.