Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade msgpack to ~>1.0 #701

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

WebFreak001
Copy link
Member

Fixes msgpack-d deprecations, allows minor bumps upstream, allows DUB dependees to use other msgpack-d versions.

@PetarKirov
Copy link
Member

Can you commit the lock file dub.selections.json? Otherwise we have no idea exactly what version you tested with (I can guess that was the latest one, but technically 1.0.1 still satisfies ~>1.0).

Fixes msgpack-d deprecations, allows minor bumps upstream

The dub.selections.json allows
@WebFreak001
Copy link
Member Author

WebFreak001 commented Jan 4, 2023

committed & adjusted CI to respect the dub.selections.json when running tests

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@PetarKirov PetarKirov merged commit 4946d49 into dlang-community:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants