Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pedantic explanation of delegate context #95

Merged
merged 2 commits into from
Sep 7, 2016
Merged

More pedantic explanation of delegate context #95

merged 2 commits into from
Sep 7, 2016

Conversation

mihails-strasuns
Copy link

Depending of actual closure allocation, delegate
context pointer may link to either enclosing function stack
or heap copy.

Depending of actual closure allocation, delegate
context pointer may link to either enclosing function stack
or heap copy.
a nested function includes a link to the enclosing context
instead. However, D compiler may automatically make a copy of
the context on the heap if it is necessary for memory safety -
in that case delegate will link the that heap area.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the that -> to this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case -> in this case

@wilzbach
Copy link
Member

wilzbach commented Sep 1, 2016

@Dicebot FYI: if you make your changes on a branch of dlang-tour - we can directly make our language nits (which you can see as amended changes). Also there is no shame in using the "edit" button and web UI (it will automatically create a branch on dlang-tour).
Might be faster & more convenient this way, but it's just an idea ;-)

@mihails-strasuns
Copy link
Author

You can simply add my remote and push to my PR branch if you want to fix some grammar bits directly. It doesn't have to be a branch of dlang-tour - I have given you push access to the fork just now.

Creating PR branches in main repo is too noisy, it should be reserved for bigger feature branches.

@wilzbach
Copy link
Member

wilzbach commented Sep 1, 2016

You can simply add my remote and push to my PR branch if you want to fix some grammar bits directly. It doesn't have to be a branch of dlang-tour - I have given you push access to the fork just now.

Okay, well the advantage of a branch being here is that immediately all collaborates have access, but yes that works for me too. Thanks!

Creating PR branches in main repo is too noisy, it should be reserved for bigger feature branches.

Argh .. you get an email whenever I create a new branch? :O
Okay then I will be less lazy in the future.

@mihails-strasuns
Copy link
Author

What is the issue with travis?

Missing index.yml for /home/travis/build/dlang-tour/tour/public/content/it

@wilzbach
Copy link
Member

wilzbach commented Sep 1, 2016

What is the issue with travis?

Yeah that's on me (with the 1.0.2 changes this fix was introduced), but it's already fixed on the main repo, so I just restarted Travis.
However it seems that the DUB registry is down at the moment :/

@PetarKirov PetarKirov merged commit 9382303 into dlang-tour:master Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants